Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Instruments] Remove/Replaces references to instrument_subtests table with getSubtestList() #7773

Closed
ridz1208 opened this issue Nov 3, 2021 · 1 comment
Closed

[Instruments] Remove/Replaces references to instrument_subtests table with getSubtestList() #7773

ridz1208 opened this issue Nov 3, 2021 · 1 comment
Assignees
@ridz1208
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties

Comments

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 3, 2021 •
edited
Loading

Describe the bug
The instrument class now expects instruments extending it (and LINST instruments) to self-define their subtest lists. A trait was added to allow for backwards compatibility for existing instruments.

Several occurrences where subtests are being queried directly from the database still exist in the code and must be replaced by the getSubtestList() function of the instrument class

occurrences:
image
@ridz1208 ridz1208 added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties Critical to release PR or issue is key for the release to which it has been assigned 23.0.0-testing 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Nov 3, 2021
@ridz1208
Copy link
Collaborator Author

ridz1208 commented Nov 3, 2021

@driusan bug might be affecting data entry in the survey module on LORIS 23 instances

@jstirling91 keep this one close, it might affect you guys

@ridz1208 ridz1208 mentioned this issue Nov 4, 2021
Closed
@ridz1208 ridz1208 removed 23.0.0-testing Critical to release PR or issue is key for the release to which it has been assigned labels Nov 16, 2021
@zaliqarosli zaliqarosli mentioned this issue Apr 5, 2023
Closed
14 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ridz1208 ridz1208

Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ridz1208 @CamilleBeau