Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[EEG pipeline] chunking data shift fix #8892

Closed
christinerogers opened this issue Sep 22, 2023 · 1 comment · Fixed by #8999
Closed

[EEG pipeline] chunking data shift fix #8892

christinerogers opened this issue Sep 22, 2023 · 1 comment · Fixed by #8999
Assignees
@jeffersoncasimir
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Sep 22, 2023 •
edited
Loading

aiming for 25.1 loris & loris-mri release : Jefferson's OHBM hackathon fix to smooth the chunking boundaries.
per Loris-eeg meeting : aim for 25.1

Solution to smooth the gap between chunks -- pass the # of data points from the last chunk into the iteration for the next chunk.

PR to come from Jefferson (for 25.1 ideally)
@christinerogers christinerogers added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 22, 2023
@christinerogers christinerogers added this to the 25.0.0 milestone Sep 22, 2023
@christinerogers christinerogers changed the title [EEG pipeline] chunking Data shift fix [EEG pipeline] chunking data shift fix Sep 22, 2023
@christinerogers christinerogers mentioned this issue Sep 22, 2023
Open
@ridz1208 ridz1208 removed this from the 25.0.0 milestone Nov 9, 2023
@jeffersoncasimir jeffersoncasimir mentioned this issue Dec 6, 2023
Merged
@jeffersoncasimir jeffersoncasimir mentioned this issue Feb 1, 2024
Merged
@jeffersoncasimir
Copy link
Contributor

Closed by #8999

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[electrophysiology_browser] Fix EEG data shift jeffersoncasimir/Loris
3 participants
@christinerogers @ridz1208 @jeffersoncasimir