From 8df3972d0a61c85598b7f9e903f2f47f12692ff1 Mon Sep 17 00:00:00 2001
From: jeffersoncasimir <jefferson.casimir@mcin.ca>
Date: Mon, 5 Jun 2023 10:26:04 -0400
Subject: [PATCH 1/2] Visibility of 'My Preferences' in menu reflects state

---
 smarty/templates/main.tpl                       | 2 ++
 src/Middleware/UserPageDecorationMiddleware.php | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/smarty/templates/main.tpl b/smarty/templates/main.tpl
index 2de87a0af93..7ad1025227b 100644
--- a/smarty/templates/main.tpl
+++ b/smarty/templates/main.tpl
@@ -155,11 +155,13 @@
                                     {$user.Real_name|escape} <b class="caret"></b>
                                 </a>
                                 <ul class="dropdown-menu">
+                                    {if $my_preferences|default}
                                     <li>
                                         <a href="{$baseurl}/my_preferences/">
                                             My Preferences
                                         </a>
                                     </li>
+                                    {/if}
                                     <li>
                                         <a href="{$baseurl}/?logout=true">
                                             Log Out
diff --git a/src/Middleware/UserPageDecorationMiddleware.php b/src/Middleware/UserPageDecorationMiddleware.php
index 0768d8894b7..f1752b19dfb 100644
--- a/src/Middleware/UserPageDecorationMiddleware.php
+++ b/src/Middleware/UserPageDecorationMiddleware.php
@@ -219,7 +219,10 @@ function ($a, $b) {
         }
         $tpl_data['userPerms'] = $realPerms;
 
-        //Display the footer links, as specified in the config file
+        // Do not show menu item if module not active
+        $tpl_data['my_preferences'] = $loris->hasModule("my_preferences");
+
+        // Display the footer links, as specified in the config file
         $links = $this->Config->getExternalLinks('FooterLink');
 
         $tpl_data['links'] = array();

From 037456ba68e14c142b03f8b54589e728f5b64fbd Mon Sep 17 00:00:00 2001
From: jeffersoncasimir <jefferson.casimir@mcin.ca>
Date: Mon, 5 Jun 2023 10:35:28 -0400
Subject: [PATCH 2/2] Changed double to single quotes for consistency

---
 src/Middleware/UserPageDecorationMiddleware.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Middleware/UserPageDecorationMiddleware.php b/src/Middleware/UserPageDecorationMiddleware.php
index f1752b19dfb..09fc7a1cf43 100644
--- a/src/Middleware/UserPageDecorationMiddleware.php
+++ b/src/Middleware/UserPageDecorationMiddleware.php
@@ -220,7 +220,7 @@ function ($a, $b) {
         $tpl_data['userPerms'] = $realPerms;
 
         // Do not show menu item if module not active
-        $tpl_data['my_preferences'] = $loris->hasModule("my_preferences");
+        $tpl_data['my_preferences'] = $loris->hasModule('my_preferences');
 
         // Display the footer links, as specified in the config file
         $links = $this->Config->getExternalLinks('FooterLink');