Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Experiment with DontPanicO's Supervisor impl. #53

Merged
merged 16 commits into from
May 3, 2023

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented May 1, 2023

This is an experimentation with @DontPanicO's Supervisor implementation,
and a demo code for the discussion thread.

This is a breaking change for aiotools, as it requires Python 3.11 to work correctly.
I will bump the aiotools version to v2.0 with this PR.

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 79.68% and project coverage change: -20.23 ⚠️

Comparison is base (13291e2) 74.88% compared to head (3f7f606) 54.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
- Coverage   74.88%   54.66%   -20.23%     
===========================================
  Files          17       19        +2     
  Lines        1322     1555      +233     
===========================================
- Hits          990      850      -140     
- Misses        332      705      +373     
Impacted Files Coverage Δ
src/aiotools/taskgroup/__init__.py 50.00% <ø> (-50.00%) ⬇️
src/aiotools/timeouts.py 70.58% <70.58%> (ø)
src/aiotools/supervisor.py 76.99% <76.99%> (ø)
src/aiotools/__init__.py 94.11% <100.00%> (+0.78%) ⬆️
src/aiotools/func.py 98.03% <100.00%> (ø)
src/aiotools/utils.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achimnol achimnol marked this pull request as ready for review May 2, 2023 14:25
@achimnol achimnol merged commit 76cdbcb into main May 3, 2023
@achimnol achimnol deleted the experiment/supervisor-and-gather-safe branch May 3, 2023 07:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant