Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provide a new config/input: version-patterns #228

Open
tomsit-ionos opened this issue Nov 26, 2024 · 1 comment
Open

provide a new config/input: version-patterns #228

tomsit-ionos opened this issue Nov 26, 2024 · 1 comment

Comments

@tomsit-ionos
Copy link

tomsit-ionos commented Nov 26, 2024

Sometimes it's much easier to define a list of positive matches of versions u want to delete instead of a single negative match regex.
B/c if u screw up that pattern, it might match way too much and will deleted version that u did not intend.

Hence i propose the following (alternative) input(s):

with:
  - include-version-patterns:
    - .*SNAPSHOT.*
    - .*alpha.*

Bonus

As the above examples already show, a list of positive patterns tends to focus on the existence of a substring. Therefore it might make sense to have these inputs:

with:
  - version-contains: #  version will be deleted if any of the patterns is contained
    - '-SNAPSHOT'
    - 'alpha'
  - version-matches: # version will be deleted  if it fully matches any of the patterns and thus implies `^<my-regex>$`
    - .*SNAPSHOT.*
    - .*alpha.*

combine or mutex these inputs ?

i personally think it's fine to AND all of the include/ignore inputs , but u may also chose to say, just one of these is allowed.

@ismailsimsek
Copy link

+1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants