Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add sanitization, validation, and basic tests for the reporting_interval input parameter #171

Open
JamesMGreene opened this issue May 15, 2023 · 0 comments
Open

Add sanitization, validation, and basic tests for the reporting_interval input parameter #171

JamesMGreene opened this issue May 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JamesMGreene
Copy link
Contributor

JamesMGreene commented May 15, 2023 •
edited
Loading

Add sanitization, validation, and basic tests for the reporting_interval input parameter.

Some possible rules:

  • ensure it is a finite number
  • ensure it is greater than 0 (we default to 5, as a point of reference)
  • ensure it is less than the finalized timeout input parameter value (which may be adjusted to MAX_TIMEOUT, depending on the user's input), otherwise it will never run

Similar to the a part of the changes made for timeout as shown in PR:

See also:
@JamesMGreene JamesMGreene added the enhancement New feature or request label May 15, 2023
This was referenced May 15, 2023
Open
Merged
@GretaP GretaP self-assigned this May 24, 2023
@GretaP GretaP removed their assignment Jun 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesMGreene @GretaP