Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The action doesn't add new labels to the PR, when changes are added to parts of the code base with associated labels #841

Open
2 of 5 tasks
nlykkei opened this issue Jan 18, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nlykkei
Copy link

nlykkei commented Jan 18, 2025

Description:
The action doesn't added labels to the PR, when new changes are added. It only removes labels, when the PR no longer changes respective files, see sync-labels: true. I need to create the labels manually before the action is able to properly label PRs.

Action version:
v5

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
NA

Expected behavior:
I would expect that labels are dynamically created and added to the PR, when changes are introduced that change other parts of the code with associated labels.

The action only supports removing labels, not adding them, on changes.

@nlykkei nlykkei added bug Something isn't working needs triage labels Jan 18, 2025
@nlykkei nlykkei changed the title The action doesn't add labels to the PR, when new changes are added to parts of the code base with associated labels The action doesn't add new labels to the PR, when changes are added to parts of the code base with associated labels Jan 18, 2025
@nlykkei nlykkei closed this as completed Jan 19, 2025
@nlykkei nlykkei reopened this Jan 21, 2025
@HarithaVattikuti
Copy link
Contributor

Hello @nlykkei
Thank you for reporting this. We will investigate the issue and get back to you as soon as we have updates.

@athackst
Copy link

I think this is the same thing as #807

I have a fork that does this -> https://github.com/athackst/labeler/tree/feature/create-labels.

Happy to PR it if there's interest

@suyashgaonkar suyashgaonkar self-assigned this Mar 11, 2025
@suyashgaonkar
Copy link
Contributor

Hi @nlykkei , with the details provided we assume that issue that you have mentioned is similar to the following issue #112. The sync-labels parameter when set to true is expected to remove labels (configured in config file) for when matching files are reverted or no longer changed by the PR. Please help us to understand the issue more by sharing the config options, workflow runs and PR where you encountered the issue that you have mentioned. You can also refer to the latest release for more details.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants