-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update yamllint to be installed using pip #1657
Comments
For information, and to support this request: the current version installed ( |
@yvele , @adrienverge , thank you for raising this point. Honestly, we are trying not install tools through I think we can consider using pipx to install CLI tools like yamllint |
I'm not a python expert, @adrienverge do you think pipx will do the job? |
I don't know pipx much, but I wouldn't recommend using it. Pip is standard, solid and tested for decades, and if an isolated environment is needed (@maxim-lobanov is it why you propose pipx?) I recommend using a virtualenv (which is a Python standard, like pip).
For info, yamllint has only 2 dependencies: pyyaml and pathspec. Hard to do less 😉 |
Hello. @adrienverge @yvele , Ubuntu images with yamlint installed via pip (pipx) was deployed everywhere. Could you please validate that it works as expected for you. |
I can confirm I have the latest yamllint version 👍 v1.25.0 Thank you @maxim-lobanov |
Cool, we also changing installation approach on other images for consistency. Will report back when it is done |
Windows and macOS images with yamlint installed via pipx was deployed everywhere also |
Tool information
Area for Triage:
Testing and code coverage
Question, Bug, or Feature?:
yamllint #1142 actually is installed using system packages see #1319 (Ubuntu) and #1320 (Windows).
But this doesn't give us the latest stable version of yamllint and is quite outdated.
We talked about that issue with the yamllint team and they suggested to use
pip
for the installation:@adrienverge
Virtual environments affected
Can this tool be installed during the build?
Tool installation time in runtime
run in 23s on
ubuntu-latest
Are you willing to submit a PR?
Yes (but I don't master Windows Server at all...)
The text was updated successfully, but these errors were encountered: