Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

actions: write is too permissive #1159

Open
avivkeller opened this issue May 30, 2024 · 2 comments · May be fixed by #1183
Open

actions: write is too permissive #1159

avivkeller opened this issue May 30, 2024 · 2 comments · May be fixed by #1183
Labels
bug Something isn't working

Comments

@avivkeller
Copy link

avivkeller commented May 30, 2024

References

#1133 / #1131
nodejs/help#4396

Issue

Currently, the stale bot (and the runner in general) require actions: write permissions to modify existing caches but not to create new ones. If actions: write permissions aren't necessary to create caches, why are they needed to update them? Could a new cache: write permission be introduced for the runner?

@HarithaVattikuti
Copy link
Contributor

Hello @redyetidev
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@ericLemanissier ericLemanissier linked a pull request Oct 16, 2024 that will close this issue
2 tasks
@ericLemanissier
Copy link

@redyetidev you probably want to try my proposition from #1183.
For this, you can replace uses: actions/stale@...with uses: actions/stale@ericLemanissier/patch-2 and remove actions: write from https://github.com/nodejs/help/blob/main/.github/workflows/close-stale-issues.yml

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants