msgpack doesn't support full range of int32

[thetazero]

CircuitPython version

7.3.0-beta.1-4-g7be66a573-dirtyAdafruit CircuitPython 7.3.0-beta.1-4-g7be66a573-dirty on 2022-04-15; PyCubedMini with samd51j19

Code/REPL

>>> msgpack.pack([1672099392], BytesIO())

Behavior

Traceback (most recent call last):
File "", line 1, in
ValueError: no default packer

Description

This behavior is seen when passing ints greater than 2^30, which seems very strange.

I suspect it has something to do with the call to the function mp_obj_is_small_int: here.

For some reason it is not entering

if (mp_obj_is_small_int(obj)) {
        // int
        int32_t x = MP_OBJ_SMALL_INT_VALUE(obj);
        pack_int(s, x);
    }

And continues until the failure case

            mp_raise_ValueError(translate("no default packer"));

Additional information

No response

[dhalbert]

I think this intersects with #6851.

[tannewt]

@thetazero Small ints are stored in 30 bits themselves because they are stored in pointers with 2 bits to indicate what type of data it is. So, you are right that the small int check isn't correct. It should be more generic to handle any int. (Ints >2**30 are stored as objects rather than small ints in a pointer.)