import hubspot rake tasks #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, this file was loading 'properties.rake' but the file was renamed to 'hubspot.rake'. This change restores the original behavior of exposing these rake tasks to end users.
Summary: Adds deprecation warnings for: - rake task hubspot:dump_properties - rake task hubspot:restore_properties - Hubspot::Utils.dump_properties - Hubspot::Utils.restore_properties We're uncertain if users find these rake tasks and functions helpful. The goal is to give the community time to react to our intent of deprecating this functionality in the v1 release. Based on that feedback, we'll proceed with one of the two options: 1) remove the functionality as planned 2) don't remove the functionality and spend time refactoring and adding additional test coverage.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to the Reviewer: This PR was reviewed and merged into
v0-stablefor thev0.6.1gem release (PR #146). This is now being merged into master so the code lives inv0.6.1and future versions.First Commit:
Summary:
Previously, this file was loading 'properties.rake' but the file was
renamed to 'hubspot.rake'. This change restores the original behavior of
exposing these rake tasks to end users.
Second Commit:
Summary:
Adds deprecation warnings for:
We're uncertain if users find these rake tasks and functions helpful.
The goal is to give the community time to react to our intent of
deprecating this functionality in the v1 release. Based on that
feedback, we'll proceed with one of the two options:
additional test coverage.