Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update contact property endpoints #166

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

SViccari
Copy link
Contributor

@SViccari SViccari commented Dec 18, 2018

Addresses Issue: #164

Summary:
Updates the endpoints listed in ContactProperties to use the new
HubSpot ContactProperty API endpoints.

The former endpoints still work because HubSpot implemented a redirect
that mapped the old endpoints to hit the new endpoints, resulting in a
response from the new endpoint.

@SViccari SViccari force-pushed the sv-update-contact-property-endpoints branch 2 times, most recently from 12e0f45 to f763c2f Compare December 18, 2018 14:34
Copy link

@MattMSumner MattMSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we're moving from a V2 to V1 but that seems to be correct. This LGTM 👍

@SViccari
Copy link
Contributor Author

@MattMSumner and I discussed the oddity of progressing from a v2 endpoint to v1 endpoint. Here's a recap of that conversation:

The new endpoint is a brand new endpoint that points to /properties. Since it's a new endpoint instead of an iteration of the /contacts endpoint, that's why the "new" endpoint is a v1 and not a v3.

Summary:
Updates the endpoints listed in `ContactProperties` to use the new
[HubSpot ContactProperty API endpoints].

The former endpoints still work because HubSpot implemented a redirect
that mapped the old endpoints to hit the new endpoints, resulting in a
response from the new endpoint.

[HubSpot ContactProperty API endpoints]:
https://developers.hubspot.com/docs/methods/contacts/contact-properties-overview
@SViccari SViccari force-pushed the sv-update-contact-property-endpoints branch from f763c2f to 8601073 Compare December 18, 2018 19:46
@SViccari SViccari merged commit 8601073 into master Dec 18, 2018
@SViccari SViccari deleted the sv-update-contact-property-endpoints branch December 18, 2018 19:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants