Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Placeholder token is never registered and set trainable #3

Open
ZichengDuan opened this issue Dec 18, 2024 · 1 comment
Open

Placeholder token is never registered and set trainable #3

ZichengDuan opened this issue Dec 18, 2024 · 1 comment

Comments

@ZichengDuan
Copy link

Thanks for presenting this work, the method is rather intuitive and effective.

However, it seems that the provided code lacks the registration of the placeholder token and consequently there are no special embeddings set to be trainable, which means that it would be impossible to reproduce the claimed performances in the ACCV paper with the code. It would be really helpful if you could kindly clarify this issue, thanks in advance.

@Fancy93
Copy link

Fancy93 commented Dec 23, 2024

Did you run this code? Did you find any other problems?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants