Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate to GitHub Actions reusable workflows #148

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Jan 29, 2025

Description

This PR migrates the repo to use the reusable workflows (tag version: gha-android-3.1.1) from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
  • Snapshot
  • Build and test
    • Migrating CircleCI -> GitHub Actions
  • Makefile - create placeholder lint for workflow
    • Out of the box workflow expects lint
  • Update Assurance Test App APK workflow
    • Stable runner version macos-latest -> macos-14
    • Update actions/ actions to latest full semantic versions
    • Replace 3rd party action for PR creation with built-in GitHub CLI gh command

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (fd5126a) to head (bad90b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #148   +/-   ##
=========================================
  Coverage     71.26%   71.26%           
  Complexity      413      413           
=========================================
  Files            66       66           
  Lines          3274     3274           
  Branches        403      403           
=========================================
  Hits           2333     2333           
  Misses          727      727           
  Partials        214      214           
Flag Coverage Δ
android-functional-tests 24.43% <ø> (?)
android-unit-tests 51.31% <ø> (?)
functional-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@prudrabhat prudrabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@timkimadobe timkimadobe merged commit 29ed972 into adobe:main Jan 31, 2025
12 checks passed
@timkimadobe timkimadobe deleted the reusable-workflows branch January 31, 2025 22:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants