dev -> staging (v3.1.0) #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to make extension compatible with Core 3.0.0
fix a path in config.yml
fix a path in config.yml
* Adopting the network service changes made in Core 3.0.0 * Update MediaSessionTests.java * Fix logs * Fix more logs * Update test for media offline service * Close connection in the correct block
emdobrin
reviewed
Mar 28, 2024
| jdk: | ||
| - openjdk17 | ||
| install: | ||
| - make ci-publish-maven-local-jitpack |
There was a problem hiding this comment.
do we need this step for media or can we rely on staging snapshots?
There was a problem hiding this comment.
We have added jitpack support to all the extensions.
kevinlind
approved these changes
Mar 28, 2024
emdobrin
reviewed
Mar 28, 2024
| implementation 'com.adobe.marketing.mobile:analytics:2.+' | ||
| implementation 'com.adobe.marketing.mobile:media:3.+' | ||
| ``` | ||
| ### Kotlin |
There was a problem hiding this comment.
nit: use h4 for code samples
| import androidx.appcompat.app.AppCompatActivity; | ||
| import com.adobe.marketing.mobile.Assurance; | ||
|
|
||
| public class MainActivity extends AppCompatActivity { |
There was a problem hiding this comment.
nit: the diff is confused and these show as new files, anything we can do to show as updated instead?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: