Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undeclared dependency on d3 #24

Closed
joestrouth1 opened this issue Dec 12, 2019 · 0 comments · Fixed by #25
Closed

Undeclared dependency on d3 #24

joestrouth1 opened this issue Dec 12, 2019 · 0 comments · Fixed by #25
Labels
bug Something isn't working npm packages Issues related to the leonardo npm packages

Comments

@joestrouth1
Copy link
Contributor

Description

The package depends on d3 to function, but does not declare it as a dependency or peer dependency. As a result, the function does not run and the package does not warn on installation.

Steps to reproduce

  1. Install the package to a fresh node project
  2. Require it in a file
  3. Write a script that runs the generateContrastColors function
  4. Execute the file

Reproduction

Expected behavior

The function should run without error and/or the package manager should warn about an unmet peer dependency.

Environment

  • @leonardo-contrast-colors version: 1.0.0-alpha.1
  • Browser(s) and OS(s): Node v10.17, v10.15

Additional context

While the readme mentions the project's use of d3 and several d3-related dependencies appear in package.json, d3 itself is absent.

PR incoming shortly

@joestrouth1 joestrouth1 added npm packages Issues related to the leonardo npm packages bug Something isn't working labels Dec 12, 2019
@joestrouth1 joestrouth1 changed the title [leonardo-contrast-colors] Undeclared dependency on d3 Undeclared dependency on d3 Dec 12, 2019
@lazd lazd closed this as completed in #25 Dec 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working npm packages Issues related to the leonardo npm packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant