Skip to content

Commit 2e02075

Browse files
committed
fix(overlay): reduce DOM and use of "display: contents" for simplicity and accessibility
1 parent b08bee3 commit 2e02075

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

packages/overlay/src/OverlayTrigger.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class OverlayTrigger extends LitElement {
9696
// Keyboard event availability documented in README.md
9797
/* eslint-disable lit-a11y/click-events-have-key-events */
9898
return html`
99-
<div
99+
<slot
100100
id="trigger"
101101
@click=${this.onTrigger}
102102
@longpress=${this.onTrigger}
@@ -105,12 +105,9 @@ export class OverlayTrigger extends LitElement {
105105
@focusin=${this.onTrigger}
106106
@focusout=${this.onTrigger}
107107
@sp-closed=${this.handleClose}
108-
>
109-
<slot
110-
@slotchange=${this.onTargetSlotChange}
111-
name="trigger"
112-
></slot>
113-
</div>
108+
@slotchange=${this.onTargetSlotChange}
109+
name="trigger"
110+
></slot>
114111
<div id="overlay-content">
115112
<slot
116113
@slotchange=${this.onClickSlotChange}

packages/overlay/src/overlay-trigger.css

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
1010
governing permissions and limitations under the License.
1111
*/
1212

13-
#trigger {
14-
display: contents;
15-
}
16-
17-
:host([disabled]) #trigger {
13+
:host([disabled]) ::slotted([slot='trigger']) {
1814
pointer-events: none;
1915
}
2016

0 commit comments

Comments
 (0)