From 3651e57a90a05e551e6ee650e8ccc73aa05d3e7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BAben=20Carvalho?= Date: Tue, 28 Jan 2025 09:02:17 +0100 Subject: [PATCH] feat(picker): add forcePopover property (#5041) Co-authored-by: Casey Eickhoff --- .circleci/config.yml | 2 +- packages/action-menu/README.md | 34 +++- .../stories/action-menu.stories.ts | 44 ++++- packages/action-menu/stories/index.ts | 8 +- .../test/action-menu-responsive.test.ts | 181 ++++++++++++++++++ packages/overlay/test/overlay.test.ts | 6 +- packages/picker/README.md | 37 +++- packages/picker/src/InteractionController.ts | 7 +- packages/picker/src/Picker.ts | 18 +- packages/picker/stories/picker.stories.ts | 73 ++++++- .../picker/test/picker-responsive.test.ts | 83 +++++++- 11 files changed, 449 insertions(+), 44 deletions(-) create mode 100644 packages/action-menu/test/action-menu-responsive.test.ts diff --git a/.circleci/config.yml b/.circleci/config.yml index f11a0272f5..21c0e27874 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -14,7 +14,7 @@ parameters: # 3. Commit this change to the PR branch where the changes exist. current_golden_images_hash: type: string - default: 93ad92a2fc031db0277fee635434955e438e94a9 + default: 266fb37749bc59cbde0e81148dddea4d1bae2053 wireit_cache_name: type: string default: wireit diff --git a/packages/action-menu/README.md b/packages/action-menu/README.md index e3dcf729a6..e9ef24d5b2 100644 --- a/packages/action-menu/README.md +++ b/packages/action-menu/README.md @@ -189,7 +189,7 @@ In order to deliver an `` without an icon, use the `label-only` ### No visible label -The visible label that is be provided via the default `` interface can be ommitted in preference of an icon only interface. In this context be sure that the `` continued to be accessible to screen readers by applying the `label` attribute. This will apply an `aria-label` attribute of the same value to the `