From 84b9df0d101d9870a1b0c20eb34ba33fcdd0fbe1 Mon Sep 17 00:00:00 2001
From: Westbrook Johnson <westbrook.johnson@gmail.com>
Date: Tue, 29 Nov 2022 18:14:34 -0500
Subject: [PATCH] fix: leverage "dvh" rather than measured screen height

---
 packages/overlay/src/ActiveOverlay.ts   | 12 +-----------
 packages/overlay/src/active-overlay.css |  2 +-
 packages/tray/src/tray.css              |  3 ++-
 3 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/packages/overlay/src/ActiveOverlay.ts b/packages/overlay/src/ActiveOverlay.ts
index c97a3637c5..b71d2d73cb 100644
--- a/packages/overlay/src/ActiveOverlay.ts
+++ b/packages/overlay/src/ActiveOverlay.ts
@@ -283,18 +283,8 @@ export class ActiveOverlay extends SpectrumElement {
 
         this.state = 'active';
 
-        // force paint
-        // this prevents a timing issue that can show up in tests as
-        // 'Error: Timeout: Wait for decorator to become ready...'
-        this.offsetWidth;
-
         this.feature();
-        if (this.placement === 'none') {
-            this.style.setProperty(
-                '--swc-visual-viewport-height',
-                `${window.innerHeight}px`
-            );
-        } else if (this.placement) {
+        if (this.placement && this.placement !== 'none') {
             await this.updateOverlayPosition();
             document.addEventListener(
                 'sp-update-overlays',
diff --git a/packages/overlay/src/active-overlay.css b/packages/overlay/src/active-overlay.css
index 963e083de1..cbc74ba212 100644
--- a/packages/overlay/src/active-overlay.css
+++ b/packages/overlay/src/active-overlay.css
@@ -50,8 +50,8 @@ governing permissions and limitations under the License.
 :host([placement='none']) {
     position: fixed;
     height: 100vh;
+    height: 100dvh;
     height: fill-available;
-    max-height: var(--swc-visual-viewport-height);
     top: 0;
     left: 0;
 }
diff --git a/packages/tray/src/tray.css b/packages/tray/src/tray.css
index 63a355505b..03ce6a6820 100644
--- a/packages/tray/src/tray.css
+++ b/packages/tray/src/tray.css
@@ -16,7 +16,8 @@ governing permissions and limitations under the License.
 :host {
     align-items: flex-end;
     position: fixed !important;
-    max-height: var(--swc-visual-viewport-height);
+    max-height: 100vh;
+    max-height: 100dvh;
 }
 
 sp-underlay {