fix(textfield): add rows attribute #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/spectrum-web-components into ingo/add-rows-property
…er/spectrum-web-components into ingo/add-rows-property
13 tasks
Tachometer resultsChromenumber-field permalink
search permalink
slider permalink
textfield permalink
Firefoxnumber-field permalink
search permalink
slider permalink
textfield permalink
|
Westbrook
reviewed
Jun 23, 2023
There was a problem hiding this comment.
This looks good to me. We've got one piece left and we'll be ready to merge. Can you checkout the docs on Visual Regression Testing and update the golden images hash? Feel free to message me here or in Slack if any of that is unclear.
Thanks!
packages/textfield/src/textfield.css
Outdated
Comment on lines
162
to
163
| block-size: auto; | ||
| resize: none; |
There was a problem hiding this comment.
These lines should already be covered by line 157/8 from above. Can we remove?
There was a problem hiding this comment.
Yes, I cleaned it up. Thanks for spotting it
| @@ -97,6 +97,9 @@ export class TextfieldBase extends ManageHelpText(Focusable) { | |||
| @property({ type: Boolean, reflect: true }) | |||
| public readonly = false; | |||
|
|
|||
| @property({ type: Number }) | |||
| public rows = -1; | |||
There was a problem hiding this comment.
This makes sense to normalize across the file, thanks for calling that out!
Westbrook
changed the title
Westbrook
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Thanks @ingorichter this looks good to me. I can't guarantee a pre-shutdown release, but if not, look for this to be available shortly thereafter. Cheers!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the rows attribute to enable a multiline Textarea to show up with a predefined amount of rows. We need this feature for an existing feature where we replace all react-spectrum components with spectrum-web-components.
Related issue(s)
Motivation and context
Product required for Adobe Share Dialog
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.