fix(popover): correct tip delivery size

[Westbrook]

Description

Correct the tip size for the Popover element when positioned to the left/right of something

Related issue(s)

• fix [Bug]: Tip of popover with left/right placement renders too small #4011

How has this been tested?

• Test case 1
  1. Go here
  2. See the tip be correctly sized
• Test case 2
  1. Go here
  2. See the tip be correctly sized

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[github-actions]

Branch Preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Classic | Lightest | Medium | LTR
• Classic | Lightest | Medium | RTL
• Classic | Lightest | Large | LTR
• Classic | Lightest | Large | RTL
• Classic | Light | Medium | LTR
• Classic | Light | Medium | RTL
• Classic | Light | Large | LTR
• Classic | Light | Large | RTL
• Classic | Dark | Medium | LTR
• Classic | Dark | Medium | RTL
• Classic | Dark | Large | LTR
• Classic | Dark | Large | RTL
• Classic | Darkest | Medium | LTR
• Classic | Darkest | Medium | RTL
• Classic | Darkest | Large | LTR
• Classic | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL

[github-actions]

Tachometer results

Chrome

action-bar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	490 kB	77.96ms - 78.81ms	-	faster ✔ 0% - 3% 0.29ms - 2.38ms
branch	480 kB	78.77ms - 80.67ms	slower ❌ 0% - 3% 0.29ms - 2.38ms	-

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	656 kB	161.32ms - 164.30ms	-	unsure 🔍 -2% - +1% -3.19ms - +1.43ms
branch	646 kB	161.93ms - 165.45ms	unsure 🔍 -1% - +2% -1.43ms - +3.19ms	-

combobox permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	708 kB	560.89ms - 572.85ms	-	slower ❌ 1379% - 1430% 523.18ms - 535.19ms
branch	697 kB	37.19ms - 38.18ms	faster ✔ 93% - 93% 523.18ms - 535.19ms	-

menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	479 kB	224.23ms - 227.73ms	-	faster ✔ 7% - 10% 16.68ms - 23.98ms
branch	471 kB	243.10ms - 249.52ms	slower ❌ 7% - 11% 16.68ms - 23.98ms	-

picker permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	517 kB	590.00ms - 598.88ms	-	unsure 🔍 -1% - +1% -5.65ms - +6.11ms
branch	509 kB	590.35ms - 598.06ms	unsure 🔍 -1% - +1% -6.11ms - +5.65ms	-

popover permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	386 kB	21.17ms - 21.32ms	-	unsure 🔍 -0% - +1% -0.05ms - +0.16ms
branch	377 kB	21.11ms - 21.25ms	unsure 🔍 -1% - +0% -0.16ms - +0.05ms	-

split-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	723 kB	1858.54ms - 1861.13ms	-	unsure 🔍 +0% - +0% +0.40ms - +4.15ms
branch	713 kB	1856.20ms - 1858.91ms	unsure 🔍 -0% - -0% -4.15ms - -0.40ms	-

Firefox

action-bar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	490 kB	173.67ms - 182.41ms	-	unsure 🔍 -3% - +4% -4.63ms - +6.23ms
branch	480 kB	174.01ms - 180.47ms	unsure 🔍 -3% - +3% -6.23ms - +4.63ms	-

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	656 kB	328.37ms - 337.67ms	-	unsure 🔍 -1% - +3% -4.16ms - +8.88ms
branch	646 kB	326.08ms - 335.24ms	unsure 🔍 -3% - +1% -8.88ms - +4.16ms	-

combobox permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	708 kB	840.03ms - 846.73ms	-	slower ❌ 1139% - 1171% 772.74ms - 779.62ms
branch	697 kB	66.39ms - 68.01ms	faster ✔ 92% - 92% 772.74ms - 779.62ms	-

menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	479 kB	441.97ms - 453.43ms	-	unsure 🔍 -3% - +1% -11.77ms - +4.33ms
branch	471 kB	445.76ms - 457.08ms	unsure 🔍 -1% - +3% -4.33ms - +11.77ms	-

picker permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	517 kB	998.64ms - 1011.92ms	-	unsure 🔍 -2% - +0% -21.05ms - +4.81ms
branch	509 kB	1002.30ms - 1024.50ms	unsure 🔍 -0% - +2% -4.81ms - +21.05ms	-

popover permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	386 kB	51.87ms - 56.65ms	-	unsure 🔍 -7% - +3% -4.16ms - +1.52ms
branch	377 kB	54.05ms - 57.11ms	unsure 🔍 -3% - +8% -1.52ms - +4.16ms	-

split-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	723 kB	1572.31ms - 1576.29ms	-	unsure 🔍 -0% - +0% -1.02ms - +5.22ms
branch	713 kB	1569.79ms - 1574.61ms	unsure 🔍 -0% - +0% -5.22ms - +1.02ms	-

[najikahalsema]

lgtm! I wonder why this slipped through our VRTs....