fix(underlay): dispatch a "close" event rather than relying naively on "click" #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChromeaction-menu permalink
dialog permalink
picker permalink
split-button permalink
tray permalink
underlay permalink
Firefoxaction-menu permalink
dialog permalink
picker permalink
split-button permalink
tray permalink
underlay permalink
|
|
I'm just using emulated mobile behaviors in Chrome, which isn't always 100% accurate, but the picker doesn't stay open in this case: mobile-picker.mov |
|
@hunterloftis that is NOT the experience that I was addressing, but I'll dig into that, too! 😳 In a mobile context, so smaller window but still touch, a Tray will be opened with an Underlay, instead of the Popover. That is hopefully addressed by this change. Will report back when I know more about touch more broadly. |
hunterloftis
previously approved these changes
Feb 8, 2024
najikahalsema
previously approved these changes
Feb 8, 2024
Westbrook
dismissed stale reviews from najikahalsema and hunterloftis
via
241e661
Westbrook
force-pushed
the
picker-mobile
branch
from
858750c to
241e661
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relying on
clickdirectly means that patterns that open an Overlay onpointerdown, like<sp-picker>, could inadvertently close the Overlay as part of that initial interaction.How has this been tested?
Types of changes
Checklist