-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(badge): updated non semantics docs for mod override #4162
Conversation
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromebadge permalinkbasic-test
Firefoxbadge permalinkbasic-test
|
Interesting. I wish I could keep the historical trajectory of every component in my mind, but alas here is one that I can't. I can say how we got to where we are now, but it seems that being these Related, it seems that there are about 9 variants that we aren't supporting here: https://github.com/adobe/spectrum-web-components/blob/main/packages/badge/src/spectrum-badge.css#L269-L274 Would you be able to include those in the CSS processing and the various pieces of documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Catching up main
and then let’s merge this in!
4a431b6
to
68619e3
Compare
Description
Updated the
--mod-badge-background-color-default
override forseafoam,indigo,purple,fuchsia,magenta,yellow
non semantic variants property which should beRelated issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.