Skip to content

[Feat]: Support pending state for Combobox #4382

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
1 task done
Rocss opened this issue May 2, 2024 · 0 comments · Fixed by #4462
Closed
1 task done

[Feat]: Support pending state for Combobox #4382

Rocss opened this issue May 2, 2024 · 0 comments · Fixed by #4462
Labels
enhancement New feature or request triage An issue needing triage

Comments

@Rocss
Copy link
Contributor

Rocss commented May 2, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-combobox

Description of the requested feature

Similar to sp-picker, sp-combobox should support a pending property which puts the component in a loading state.
The style for this is available in Spectrum CSS.

Mockups or screenshots

Screenshot 2024-05-02 at 10 35 09

Implementation notes or ideas

When in a pending state, a combobox:

  • receives focus, but does not open the option list on click, type, or arrow-down
  • displays a loading spinner using sp-progress-circle, which has an aria-label provided via pendingLabel property
  • allows typing, but does not display the list of autocompleted options when autocomplete=list
@Rocss Rocss added enhancement New feature or request triage An issue needing triage labels May 2, 2024
@Rocss Rocss linked a pull request May 16, 2024 that will close this issue
18 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant