fix: add keyboard handlers to sp-table-cell-head

[jnurthen]

Description

Adds keyboard handlers to sp-table-cell-head

Related issue(s)

#4472

Motivation and context

Keyboard handlers needed for accessibility.

How has this been tested?

• Test case 1
  1. Go to Storybook
  2. Tab to Column Title (sortable)
  3. Press Enter
  4. sort activates
  5. Press and release space
  6. sort activates

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Spectrum | Lightest | Medium | LTR
• Spectrum | Lightest | Medium | RTL
• Spectrum | Lightest | Large | LTR
• Spectrum | Lightest | Large | RTL
• Spectrum | Light | Medium | LTR
• Spectrum | Light | Medium | RTL
• Spectrum | Light | Large | LTR
• Spectrum | Light | Large | RTL
• Spectrum | Dark | Medium | LTR
• Spectrum | Dark | Medium | RTL
• Spectrum | Dark | Large | LTR
• Spectrum | Dark | Large | RTL
• Spectrum | Darkest | Medium | LTR
• Spectrum | Darkest | Medium | RTL
• Spectrum | Darkest | Large | LTR
• Spectrum | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Light | Medium | RTL
• Spectrum-two | Light | Large | LTR
• Spectrum-two | Light | Large | RTL
• Spectrum-two | Dark | Medium | LTR
• Spectrum-two | Dark | Medium | RTL
• Spectrum-two | Dark | Large | LTR
• Spectrum-two | Dark | Large | RTL

[github-actions]

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	222.694 kB	210.485 kB 🏆	210.904 kB
Scripts	54.665 kB	48.269 kB 🏆	48.426 kB
Stylesheet	34.987 kB	30.308 kB 🏆	30.538 kB
Document	6.026 kB	5.304 kB	5.30 kB 🏆
Font	127.016 kB	126.604 kB 🏆	126.64 kB

Request Count

Category	Latest	Main	Branch
Total	45	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

[github-actions]

Tachometer results

Chrome

table permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	531 kB	122.31ms - 124.77ms	-	faster ✔ 2% - 5% 2.08ms - 6.92ms
branch	493 kB	125.96ms - 130.13ms	slower ❌ 2% - 6% 2.08ms - 6.92ms	-

Firefox

table permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	531 kB	268.58ms - 277.70ms	-	unsure 🔍 -3% - +1% -8.92ms - +3.96ms
branch	493 kB	271.07ms - 280.17ms	unsure 🔍 -1% - +3% -3.96ms - +8.92ms	-

[Westbrook]

Can you ever get a keyup on Space that didn't previously have a keydown on Space? In that case that you can't, which is how I understand this to work, could we simplify and have keyup be the persistent listener and not require the keydown listener at all?

[jnurthen]

honestly I copied this from swatch which was doing the same thing. Happy to simplify if that makes sense - I just assumed there was a good reason for it.

[Rajdeepc]

One small addition needs to go in to the definition of this class. Can you make sure it is added before we can land this!

[Rajdeepc]

LGTM!