Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FEATURE REQUEST - drawio support #6

Closed
mat-inf opened this issue Jun 1, 2023 · 5 comments
Closed

FEATURE REQUEST - drawio support #6

mat-inf opened this issue Jun 1, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@mat-inf
Copy link

mat-inf commented Jun 1, 2023

Hey,

Thanks for creating such a useful mkdocs plugin. I really like your work!
As you mentioned on the Repositories README, I would like to request an additional feature:

Currently, I'm using a plugin for embedding drawio diagrams into mkdocs (More Information about the Plugin). Basically, the plugin simplifies the workflow of embedding a diagram by allowing to embed the .drawio file directly instead of exporting the diagram to a .svg and embed this.
I tried to export PDFs with your exporter, which works perfectly fine, but I wasn't able to export a site with the drawio Diagram. There was no Error and the export works, the diagram just wasn't showing in the exported PDF.
So my guess was that this is just not supported by your plugin.

I would be very happy if you could include this feature. Feel free to contact me about further questions or if I can be of assistance.

@adrienbrignon
Copy link
Owner

Hey @mat-inf,

First of all, thank your for submitting an issue and for your kind words.

That's a great idea!
I'll see what I can do in implementing this feature; stay tuned.

@adrienbrignon adrienbrignon added the enhancement New feature or request label Jun 2, 2023
@adrienbrignon
Copy link
Owner

adrienbrignon commented Jun 2, 2023

Hello again @mat-inf,

Could you please try updating to v3.0.3 and tell me if that works now?

It seems that the diagrams do not properly scale when rendered in a PDF document.
I guess that this could be fixed with some CSS/JS but it is currently out of the scope of this project.

@mat-inf
Copy link
Author

mat-inf commented Jun 2, 2023

Hey @adrienbrignon

I did the upgrade to v3.0.3 and it works now. Is this feature now integrated or was this just a workaround?

@adrienbrignon
Copy link
Owner

Thanks for testing, glad to hear that it works now!

This was a simple workaround, re-enabling JavaScript in the browser rendering PDF documents fixed the issue 😄

@mat-inf
Copy link
Author

mat-inf commented Jun 2, 2023

Thanks a lot!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants