declare when not building snapshot

aduh95 · Feb 16, 2025 · af7bb75 · af7bb75
1 parent c89ce29
commit af7bb75
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/lib/internal/bootstrap/web/exposed-wildcard.js b/lib/internal/bootstrap/web/exposed-wildcard.js
@@ -11,6 +11,7 @@ const {
 } = primordials;
 
 const {
+  doWhenNotBUildingSnapshot,
   exposeInterface,
   exposeLazyInterfaces,
   exposeNamespace,
@@ -27,7 +28,7 @@ const { URL, URLSearchParams } = require('internal/url');
 exposeInterface(globalThis, 'URL', URL);
 // https://url.spec.whatwg.org/#urlsearchparams
 exposeInterface(globalThis, 'URLSearchParams', URLSearchParams);
-exposeLazyDOMExceptionProperty(globalThis);
+doWhenNotBUildingSnapshot(() => exposeLazyDOMExceptionProperty(globalThis));
 
 // https://dom.spec.whatwg.org/#interface-abortcontroller
 // Lazy ones.

diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -55,7 +55,7 @@ const {
 const { signals } = internalBinding('constants').os;
 const {
   guessHandleType: _guessHandleType,
-  defineLazyProperties,
+  defineLazyProperties: _defineLazyProperties,
   privateSymbols: {
     arrow_message_private_symbol,
     decorated_private_symbol,
@@ -66,6 +66,10 @@ const { isNativeError, isPromise } = internalBinding('types');
 const { getOptionValue } = require('internal/options');
 const assert = require('internal/assert');
 const { encodings } = internalBinding('string_decoder');
+const {
+  isBuildingSnapshot,
+  addDeserializeCallback,
+} = require('internal/v8/startup_snapshot').namespace;
 
 const noCrypto = !process.versions.openssl;
 const noTypeScript = !process.versions.amaro;
@@ -611,6 +615,18 @@ function exposeGetterAndSetter(target, name, getter, setter = undefined) {
   });
 }
 
+function doWhenNotBUildingSnapshot(fn) {
+  if (isBuildingSnapshot()) {
+    addDeserializeCallback(fn);
+  } else {
+    fn();
+  }
+}
+
+function defineLazyProperties(...args) {
+  doWhenNotBUildingSnapshot(() => ReflectApply(_defineLazyProperties, this, args));
+}
+
 function defineReplaceableLazyAttribute(target, id, keys, writable = true, check) {
   let mod;
   for (let i = 0; i < keys.length; i++) {
@@ -852,6 +868,7 @@ module.exports = {
   defineReplaceableLazyAttribute,
   deprecate,
   deprecateInstantiation,
+  doWhenNotBUildingSnapshot,
   emitExperimentalWarning,
   encodingsMap,
   exposeInterface,