Skip to content

0.1.25 breaks existing implementation #70

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Nantris opened this issue Apr 24, 2020 · 6 comments
Closed

0.1.25 breaks existing implementation #70

Nantris opened this issue Apr 24, 2020 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@Nantris
Copy link

Nantris commented Apr 24, 2020

Describe the bug
I won't have time to document this well and we're opting to stay on 0.1.25, but I wanted to report that code we have that collapses the space when it's dragged to a size smaller than the minimum defined no longer works properly.

Is there any changelog for versions beyond 0.1.23? Maybe that will make it obvious where things are going wrong.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser Electron@8.2.x
  • Version 0.1.25
@aeagle aeagle added the bug Something isn't working label Apr 25, 2020
@aeagle
Copy link
Owner

aeagle commented Apr 25, 2020

Hi @slapbox - sorry refer to https://www.allaneagle.com/react-spaces/docs/?path=/docs/react-spaces-change-history--page

There is a refactor in 0.1.25 which involves the resizing which was intended as preparation for future enhancements but it sounds like this has caused you issues.

I'm moving things around at the moment and in the middle of a rewrite of spaces (see #69 for details). It might be worth sticking on the version that works for you at the moment and moving to the newer version once the rewrite is finished in relation to #69.

@Nantris
Copy link
Author

Nantris commented Apr 25, 2020

I'm very happy on 0.1.24 and ready to stay put for a while. Just wanted to give you a heads up that something had functionally changed.

Thanks for the update and your great work @aeagle.

@aeagle aeagle added this to the 0.2.0 milestone Apr 27, 2020
@Kilian
Copy link

Kilian commented Jun 4, 2020

Can confirm that for custom spaces, minimumSize seems to no longer be applied either

@aeagle aeagle added v0.1.26 and removed v0.2.0 labels Sep 16, 2020
@aeagle aeagle modified the milestones: 0.2.0, 0.1.26 Sep 16, 2020
@aeagle
Copy link
Owner

aeagle commented Sep 23, 2020

Could be related to issue #73 with fix currently being reviewed on PR #74. Need to check after PR #74 applied.

@aeagle
Copy link
Owner

aeagle commented Sep 24, 2020

@slapbox There is a small possibility that your issue with v0.1.25 has been fixed with a fix applied in #74 which has been released in v0.1.26.

@Nantris
Copy link
Author

Nantris commented Nov 26, 2020

@aeagle thanks for the follow-up! I actually scrapped my existing code and have been rewriting it from scratch (still using React-Spaces, it's so great!)

My guess though is that #74 would have fixed my issue though, so I'll close this.

Thanks again for all your help and awesome work!

@Nantris Nantris closed this as completed Nov 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants