Skip to content

Commit b221cde

Browse files
committed
[Java] Tidy up after merge of PR #834.
1 parent 2076d25 commit b221cde

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,14 @@ private void generateGroupDecoderClassHeader(
418418
.append(indent).append(" return this;\n")
419419
.append(indent).append(" }\n");
420420

421+
final String numInGroupJavaTypeName = javaTypeName(numInGroupType);
422+
final String numInGroupMinValue = generateLiteral(
423+
numInGroupType, numInGroupToken.encoding().applicableMinValue().toString());
424+
generatePrimitiveFieldMetaMethod(sb, indent, numInGroupJavaTypeName, "count", "Min", numInGroupMinValue);
425+
final String numInGroupMaxValue = generateLiteral(
426+
numInGroupType, numInGroupToken.encoding().applicableMaxValue().toString());
427+
generatePrimitiveFieldMetaMethod(sb, indent, numInGroupJavaTypeName, "count", "Max", numInGroupMaxValue);
428+
421429
sb.append("\n")
422430
.append(indent).append(" public static int sbeHeaderSize()\n")
423431
.append(indent).append(" {\n")
@@ -484,20 +492,12 @@ private void generateGroupEncoderClassHeader(
484492

485493
final PrimitiveType numInGroupType = numInGroupToken.encoding().primitiveType();
486494

487-
final String javaTypeName = javaTypeName(numInGroupType);
488-
final String minValue = generateLiteral(numInGroupType,
489-
numInGroupToken.encoding().applicableMinValue().toString());
490-
generatePrimitiveFieldMetaMethod(sb, ind, javaTypeName, "count", "Min", minValue);
491-
final String maxValue = generateLiteral(numInGroupType,
492-
numInGroupToken.encoding().applicableMaxValue().toString());
493-
generatePrimitiveFieldMetaMethod(sb, ind, javaTypeName, "count", "Max", maxValue);
494-
495-
final PrimitiveType newInGroupTypeCast = PrimitiveType.UINT32 == numInGroupType ?
495+
final PrimitiveType numInGroupTypeCast = PrimitiveType.UINT32 == numInGroupType ?
496496
PrimitiveType.INT32 : numInGroupType;
497497
final String numInGroupOffset = "limit + " + numInGroupToken.offset();
498498
final String numInGroupValue = "count";
499499
final String numInGroupPut = generatePut(
500-
newInGroupTypeCast, numInGroupOffset, numInGroupValue, byteOrderString(numInGroupToken.encoding()));
500+
numInGroupTypeCast, numInGroupOffset, numInGroupValue, byteOrderString(numInGroupToken.encoding()));
501501

502502
new Formatter(sb).format("\n" +
503503
ind + " public void wrap(final %2$s buffer, final int count)\n" +
@@ -540,7 +540,7 @@ private void generateGroupEncoderClassHeader(
540540

541541
final String countOffset = "initialLimit + " + numInGroupToken.offset();
542542
final String resetCountPut = generatePut(
543-
newInGroupTypeCast, countOffset, numInGroupValue, byteOrderString(numInGroupToken.encoding()));
543+
numInGroupTypeCast, countOffset, numInGroupValue, byteOrderString(numInGroupToken.encoding()));
544544

545545
sb.append("\n")
546546
.append(ind).append(" public int resetCountToIndex()\n")
@@ -550,6 +550,14 @@ private void generateGroupEncoderClassHeader(
550550
.append(ind).append(" return count;\n")
551551
.append(ind).append(" }\n");
552552

553+
final String numInGroupJavaTypeName = javaTypeName(numInGroupType);
554+
final String numInGroupMinValue = generateLiteral(
555+
numInGroupType, numInGroupToken.encoding().applicableMinValue().toString());
556+
generatePrimitiveFieldMetaMethod(sb, ind, numInGroupJavaTypeName, "count", "Min", numInGroupMinValue);
557+
final String numInGroupMaxValue = generateLiteral(
558+
numInGroupType, numInGroupToken.encoding().applicableMaxValue().toString());
559+
generatePrimitiveFieldMetaMethod(sb, ind, numInGroupJavaTypeName, "count", "Max", numInGroupMaxValue);
560+
553561
sb.append("\n")
554562
.append(ind).append(" public static int sbeHeaderSize()\n")
555563
.append(ind).append(" {\n")

0 commit comments

Comments
 (0)