Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GitHub Actions: Add testing on Windows #322

Open
cclauss opened this issue May 16, 2024 · 2 comments
Open

GitHub Actions: Add testing on Windows #322

cclauss opened this issue May 16, 2024 · 2 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented May 16, 2024

Currently testing on Windows is commented out in our GitHub Actions.

# - os: windows-latest # TODO: Fix the Windows test that runs in an infinite loop
# python-version: '3.13'

Linux and macOS work just fine but on Windows the tests never complete.

@ddelange
Copy link
Contributor

here are the pytest failues on windows: #294 (comment)

when they're fixed (or skipped), we could re-introduce pytest in wheels.yml (84667ee) to get proper platform tests:

  • ci.yml would run pytest for different python versions (linux only)
  • wheels.yml would run pytest for different (emulated) cpu architectures and operating systems (including the different mac and windows flavours)

@cclauss
Copy link
Contributor Author

cclauss commented May 23, 2024

I prefer a test job that runs the tests.
And a separate wheels / deployment job that is focused on moving to production. However I don’t want to do anything that slows down this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants