Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inconsistency if focus state in dark mode on the website. #641

Closed
1 task done
vatsalsinghkv opened this issue Oct 3, 2023 · 10 comments · Fixed by #777
Closed
1 task done

Inconsistency if focus state in dark mode on the website. #641

vatsalsinghkv opened this issue Oct 3, 2023 · 10 comments · Fixed by #777
Assignees

Comments

@vatsalsinghkv
Copy link
Contributor

Describe the feature

Focus state of the website on light mode is of the accent colour. But in the dark mode they're not of the accent colour.

I would like to fix this inconsistency under hacktoberfest

Light Mode

Screenshot 2023-10-03 at 11 54 19 AM

Dark Mode

Screenshot 2023-10-03 at 11 53 54 AM

Additional information

  • Would you be willing to help implement this feature?
@Yasir761
Copy link

Yasir761 commented Oct 3, 2023

Hey, @vatsalsinghkv are you working on this? If not can you please assign it to me under Hacktoberfest tag.

@vatsalsinghkv
Copy link
Contributor Author

@Yasir761 I want to work on this tbh. It took quite a time to find such visual issues so.

@Yasir761
Copy link

Yasir761 commented Oct 3, 2023

@vatsalsinghkv It's ok, I understand.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 3, 2023

Hi @vatsalsinghkv. Thank you for the observation. You can, go ahead and work on this.
When you create a PR, please attach a screenshot of the changes and also confirm that it has a good contrast ratio so that it is accessible.

@tobySolutions
Copy link
Contributor

Awesome! Thank you very much @vatsalsinghkv!

@tobySolutions
Copy link
Contributor

Hey there @vatsalsinghkv; any updates on this at the moment?

@Yasir761
Copy link

@tobySolutions can I work on this, if there is no update

@tobySolutions
Copy link
Contributor

Hmm, I'll review your PR soon @vatsalsinghkv. Thanks!

@vatsalsinghkv
Copy link
Contributor Author

@tobySolutions please review the PR for this issue

@tobySolutions
Copy link
Contributor

@tobySolutions please review the PR for this issue

Awesome! Reviewing it now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants