Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(sink): qr code generator #631

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

aelew
Copy link
Contributor

@aelew aelew commented Oct 1, 2023

Please describe the changes this PR makes and why it should be merged:
This PR adds a QR code generator to the Kitchen Sink.
Closes #627.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 7:02am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 7:02am

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2023

CLA assistant check
All committers have signed the CLA.

Co-authored-by: deeola <71495600+deeola@users.noreply.github.com>
@aidenybai
Copy link
Owner

Thank you for the contribution @aelew!

@aidenybai aidenybai merged commit a334f16 into aidenybai:main Oct 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A QR Code Generator:
4 participants