-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add expense tracker to kitchen skin #655
feat: add expense tracker to kitchen skin #655
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sure thing! @vimode! Reviewing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Interesting usage of the block function though. Is there a reason as to your usage in just the ExpenseItem
Hey @tobySolutions Thank you for the review. If I use the block function on the whole app. the way I have the form inputs be handled by the parent component causes the whole app to re-render(?) so when one starts typing, it loses focus on the input on every key stroke. But I think moving the state locally to the component should fix that issue. Let me try and fix this accordingly. |
Hey @tobySolutions I millionified it a bit more! 🦁 |
Good work @vimode! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Please describe the changes this PR makes and why it should be merged:
This PR adds Expense tracker example to the list of Kitchen Sink examples as per #606
I ran the
pnpm cleanup
command and it modified a lot of files, but I only pushed the changes for this project file and nothing more, hope thats okay.The
pnpm lint
andpnpm test
command and all seems OK.My knowledge of TS and million is very basic so please recommend fixes as needed.
If there is any missing feature in the current implementation of the project or some logic that seems odd or need fixing, I am ready to work on it as needed.
Thank you.
Status
Semantic versioning classification: