Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Kitchen Sink: Type Racing Game added #704

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Kitchen Sink: Type Racing Game added #704

merged 5 commits into from
Oct 14, 2023

Conversation

izruff
Copy link
Contributor

@izruff izruff commented Oct 7, 2023

Please describe the changes this PR makes and why it should be merged:

This PR implements the game "type race" where users type quickly to score higher.

Status

Closes #663

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:34am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:34am

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Timonwa
Timonwa approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Timonwa Timonwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And I enjoyed playing the game. Can you resolve your merge conflict so your PR can be merged?

@izruff
Copy link
Contributor Author

izruff commented Oct 9, 2023

@Timonwa thank you! I have resolved it, please check

@Timonwa
Copy link
Contributor

Timonwa commented Oct 9, 2023

@tobySolutions, Can you merge this? It's good to go.

tobySolutions
tobySolutions approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just please resolve your merge conflicts please. Thank you so much!

@tobySolutions
Copy link
Contributor

Also, can you maybe try using the block function for some more components?

@Drex72
Copy link
Contributor

Drex72 commented Oct 11, 2023

also @izruff , could you also resolve your merge conflicts also

tobySolutions
tobySolutions approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions
Copy link
Contributor

Good job @izruff

@tobySolutions tobySolutions merged commit 00c9c8d into aidenybai:main Oct 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Timonwa Timonwa Timonwa approved these changes

@tobySolutions tobySolutions tobySolutions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Type Racing Game
5 participants
@izruff @CLAassistant @Timonwa @tobySolutions @Drex72