Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: focus state inconsistency #777

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

vatsalsinghkv
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

fixes #641

I have updated the nextra theme config, by changing primary hue for the dark mode.

This is the colour I picked according to the theme:
Screenshot 2023-10-17 at 10 41 13 AM

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:22am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:22am

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job.

@tobySolutions tobySolutions merged commit 42abc45 into aidenybai:main Oct 25, 2023
aidenybai added a commit that referenced this pull request Oct 25, 2023
@aidenybai
Copy link
Owner

reverted this change. I don't believe this hue fits our color scheme.

@tobySolutions
Copy link
Contributor

reverted this change. I don't believe this hue fits our color scheme.

Hmm, oh ok. I was gonna come back to this. I was seeing some weirdness.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency if focus state in dark mode on the website.
4 participants