Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: export code wrapper in modify-config #855

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Conversation

tobySolutions
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
Screenshot 2023-12-29 at 11 36 03 Screenshot 2023-12-29 at 11 36 08

I abstracted the return logic for writing into the config file in all cases into helper functions

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 10:55am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 10:55am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7356004425

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 7314175169: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@tobySolutions
Copy link
Contributor Author

@Drex72 reviewed this. Thanks Drex.

@tobySolutions tobySolutions merged commit c3ac145 into main Dec 29, 2023
3 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
* refactor: exportcode wrapper

* refactor: exportcode wrapper

* refactor: exportcode wrapper

* refactor: fix linting issues
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants