Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remix warnings #969

Merged
merged 5 commits into from
Feb 24, 2024
Merged

fix: remix warnings #969

merged 5 commits into from
Feb 24, 2024

Conversation

Aslemammad
Copy link
Collaborator

Resolves #962

#954 should be merged first.

Vite returns react for the client when it should return react-server in the client for ssr projects. Because react-server handles the hydration and not react

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7898082329

Details

  • -24 of 24 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 3.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/compiler/plugin.ts 0 8 0.0%
packages/react-server/index.ts 0 16 0.0%
Totals Coverage Status
Change from base Build 7841623579: -0.002%
Covered Lines: 884
Relevant Lines: 27080

💛 - Coveralls

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 5:00am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 5:00am

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some errors/warnings (mostly hydration) in a remix project
2 participants