Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: nextjs hmr on error #973

Merged
merged 1 commit into from
Feb 24, 2024
Merged

fix: nextjs hmr on error #973

merged 1 commit into from
Feb 24, 2024

Conversation

Aslemammad
Copy link
Collaborator

Resolves #878

Now we return an empty file so we do not break the cycle for next updates. This might not be the ideal solution since I'm not as expert as @lxsmnsyc on the compiler, but it worked.

@Aslemammad Aslemammad requested a review from lxsmnsyc February 20, 2024 07:37
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 7:37am

@Aslemammad Aslemammad merged commit 7c84b9d into main Feb 24, 2024
7 of 8 checks passed
@Aslemammad Aslemammad deleted the fix/nextjs-hmr branch February 24, 2024 04:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot Reload not working after an error in NextJS 14 with App Router
1 participant