Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor convert to op #1176

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Refactor convert to op #1176

merged 9 commits into from
Sep 28, 2023

Conversation

valer1435
Copy link
Collaborator

Closes #299

@pep8speaks
Copy link

pep8speaks commented Sep 28, 2023

Hello @valer1435! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-09-28 11:47:00 UTC

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1176 (4809b47) into master (92cee16) will increase coverage by 0.11%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   79.70%   79.81%   +0.11%     
==========================================
  Files         141      141              
  Lines        9851     9796      -55     
==========================================
- Hits         7852     7819      -33     
+ Misses       1999     1977      -22     
Files Coverage Δ
fedot/core/operations/evaluation/classification.py 96.82% <100.00%> (+2.45%) ⬆️
fedot/core/operations/evaluation/clustering.py 100.00% <100.00%> (+3.44%) ⬆️
...core/operations/evaluation/common_preprocessing.py 100.00% <100.00%> (+3.12%) ⬆️
fedot/core/operations/evaluation/gpu/clustering.py 54.54% <100.00%> (+3.19%) ⬆️
fedot/core/operations/evaluation/gpu/common.py 48.88% <100.00%> (+1.95%) ⬆️
fedot/core/operations/evaluation/regression.py 100.00% <100.00%> (+3.17%) ⬆️
fedot/core/operations/evaluation/text.py 63.29% <100.00%> (+2.85%) ⬆️
fedot/core/operations/evaluation/time_series.py 100.00% <100.00%> (+3.38%) ⬆️
...ore/operations/evaluation/evaluation_interfaces.py 86.36% <60.00%> (+0.52%) ⬆️

def _convert_to_operation(self, operation_type: str):
raise NotImplementedError()
if operation_type in self._operations_by_types.keys():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно без .keys().

@valer1435 valer1435 merged commit 2ecbc7e into master Sep 28, 2023
@valer1435 valer1435 deleted the refactor_convert_to_op branch September 28, 2023 12:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor _convert_to_operation logic
3 participants