-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor convert to op #1176
Refactor convert to op #1176
Conversation
Hello @valer1435! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-09-28 11:47:00 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
+ Coverage 79.70% 79.81% +0.11%
==========================================
Files 141 141
Lines 9851 9796 -55
==========================================
- Hits 7852 7819 -33
+ Misses 1999 1977 -22
|
def _convert_to_operation(self, operation_type: str): | ||
raise NotImplementedError() | ||
if operation_type in self._operations_by_types.keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно без .keys()
.
Closes #299