Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the rule for time series pipeline verification #1210

Merged
merged 25 commits into from
Dec 15, 2023

Conversation

kasyanovse
Copy link
Collaborator

Add new check for time series specific primary node in pipeline.

@kasyanovse kasyanovse added core Core logic related to graph optimisation time series related to time series processing labels Nov 29, 2023
@kasyanovse kasyanovse self-assigned this Nov 29, 2023
@kasyanovse kasyanovse force-pushed the improve_verfier_for_ts branch from 2db31d6 to 1e2a6e8 Compare November 29, 2023 12:39
@pep8speaks
Copy link

pep8speaks commented Nov 29, 2023

Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-15 13:57:37 UTC

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (70d470a) 79.15% compared to head (f0811cc) 79.45%.

Files Patch % Lines
fedot/core/pipelines/verification_rules.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   79.15%   79.45%   +0.29%     
==========================================
  Files         145      145              
  Lines        9937     9928       -9     
==========================================
+ Hits         7866     7888      +22     
+ Misses       2071     2040      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorrisNein MorrisNein requested review from MorrisNein and removed request for MorrisNein November 30, 2023 12:44
@kasyanovse kasyanovse force-pushed the improve_verfier_for_ts branch from c81a444 to 52e1353 Compare December 1, 2023 14:47
@kasyanovse kasyanovse force-pushed the improve_verfier_for_ts branch from 52e1353 to 77d87fe Compare December 4, 2023 10:18
@nicl-nno nicl-nno requested a review from Lopa10ko December 4, 2023 10:52
Copy link
Collaborator

@Lopa10ko Lopa10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>
@kasyanovse kasyanovse requested a review from Lopa10ko December 4, 2023 11:18
@kasyanovse kasyanovse merged commit 299ffba into master Dec 15, 2023
@kasyanovse kasyanovse deleted the improve_verfier_for_ts branch December 15, 2023 14:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Core logic related to graph optimisation time series related to time series processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants