-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix gensim for PyPi release #1287
Conversation
👋 Hi, I'm @Docu-Mentor, an LLM-powered GitHub app Simply create a new comment in this PR that says: @Docu-Mentor run and I will start my analysis. I only look at what you changed @Docu-Mentor run doc/ README.md In this example, I'll have a look at all files contained in the "doc/" |
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
+ Coverage 79.88% 79.90% +0.02%
==========================================
Files 146 146
Lines 10065 10066 +1
==========================================
+ Hits 8040 8043 +3
+ Misses 2025 2023 -2 ☔ View full report in Codecov by Sentry. |
gensim редко релизится, версию специально брали с определенного коммита из-за падения интеграционников подробнее проблема описана здесь pypi не поддерживает такие зависимости, но должны быть workaround'ы или нужно, наверное, менять версию scipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
было бы замечательно еще несколько раз локально проверить модульные тесты и конкретный интеграционник, который падал раньше + запустить интеграционники в github actions пару раз, чтобы убедиться, что нет с ними проблем
Да, так и планировал делать. |
✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866144787 |
❌ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866585903 |
✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866859667 |
✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8867155981 |
✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8937098133 |
Тесты проходят и для Голема - aimclub/GOLEM#274 |
41e9c24
to
26ce738
Compare
* update version of codecov github action (#1289) * Fix gitlab mirroring (#1288) * Fix gensim for PyPi release (#1287) * pin scipy version * pin gensim version * pin unyanked scipy version * pin scipy versions to python versions * simplify pin for scipy --------- Co-authored-by: Elizaveta Lutsenko <skystar-el@yandex.ru>
This is a 🐛 bug fix
Summary
Fix gensim problem with pinned dependencies versions
Context
PyPi intermediate release 0.7.3.2 doesn't publish:
https://github.com/aimclub/FEDOT/actions/runs/8849483743/job/24301597093