-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
hotfix: go for FeaturesType instead of InputData in a pipeline tuning #1311
Conversation
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1311 +/- ##
=======================================
Coverage 79.93% 79.94%
=======================================
Files 146 146
Lines 10097 10102 +5
=======================================
+ Hits 8071 8076 +5
Misses 2026 2026 ☔ View full report in Codecov by Sentry. |
fedot/api/main.py
Outdated
if input_data is None: | ||
input_data = self.train_data | ||
else: | ||
input_data = self.data_processor.define_data(features=input_data, target=self.target, is_predict=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если подаются новые данные для тюнинга, то у них скорее всего будет новый и target
. Поэтому в tune
нужно по аналогии и target: TargetType = 'target'
добавить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lopa10ko Я мб еще учел если у нас input_data is None
. то target
должен быть также self.target
. Или при вызове define_data
он таким же и будет?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
кажется, если input_data is None
, то пост-тюнинг запускают на уже обработанных данных (на self.train_data
), просто на этот раз дольше, например
а возможность запустить с указанными данными нужна в случае, если тюним на данных, которые не видели раньше (тогда и указываем FeaturesType
+ TargetType
)
This is a 🙋 feature or enhancement.
Summary
tune
function so that theinput_data
param can be of typeFeaturesType
. This allows passing one of the following data formats:str, PathLike, numpy array, pandas DataFrame, FEDOT-native InputData, FEDOT-native MultiModalData, dictionary, or tuple
add unit tests with different data formats(covered withtest/unit/api/test_main_api
andtest/integration/pipelines/tuning/test_pipeline_tuning
)Context
related to discussion in #1298