Release fixes for multi-objective optimization #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Может это каким-то высокоуровневым тестом заодно проверить? Например, для пары целевых функций, где одна - число узлов в графе со знаком плюс, а другая - со знаком минус. Тогда оптимизатор должен найти полный набор. |
nicl-nno
reviewed
Dec 1, 2022
nicl-nno
reviewed
Dec 1, 2022
YamLyubov
requested changes
Dec 2, 2022
| @@ -57,12 +64,15 @@ class GenerationKeeper(ImprovementWatcher): | |||
| NB: relevant only for single-objective optimization. | |||
| initial_generation: Optional first generation; | |||
| NB: if None then keeper is created in inconsistent state and requires an initial .append(). | |||
| similar: a function that tells in the case of multi-objective optimization | |||
| tells the Pareto front whether or not two individuals are similar, optional. | |||
There was a problem hiding this comment.
Тут очепятка: два раза tells
Добавил интеграционный тест в fcfee61 |
nicl-nno
approved these changes
Dec 8, 2022
YamLyubov
approved these changes
Dec 9, 2022
gkirgizov
force-pushed
the
release_fixes
branch
from
92ef832 to
6d43d48
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes came from experiments with abstract graph optimization (synthtic task) that seems necessary for the release.
Apparently, Multi-Objective optimization was broken.
Also closes #997