Allows selecting the end date first for unattached vertically oriented datepickers #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
force-pushed
the
maja-fix-vertical-datepicker-focus-logic
branch
from
2f63852 to
71f9c88
Compare
majapw
force-pushed
the
maja-fix-vertical-datepicker-focus-logic
branch
from
71f9c88 to
b53bed3
Compare
ljharb
added
the
semver-major: breaking change
ljharb
reviewed
Oct 31, 2016
|
|
||
| if (!startDate && orientation === VERTICAL_ORIENTATION && !disabled) { | ||
| // Since the vertical datepicker is full screen, we never want to focus the end date first | ||
| if (!startDate && withFullScreenPortal && !disabled) { |
There was a problem hiding this comment.
do we want to keep this as semver-minor by leaving the vertical orientation check in place?
There was a problem hiding this comment.
well but the old behavior was like, broken. So I think this needs to stay.
ljharb
approved these changes
Nov 1, 2016
majapw
commented
Nov 1, 2016
| @@ -894,12 +894,12 @@ describe('DateRangePicker', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('props.orientation = VERTICAL_ORIENTATION', () => { | |||
| describe('props.withFullScreenPortal is truthy', () => { | |||
There was a problem hiding this comment.
This is the test @ljharb
majapw
added
semver-patch: fixes/refactors/etc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was behavior from back when we assume the vertical orientation would only ever be used on mobile devices and with a portal. This fixes the assumption.
to: @airbnb/webinfra