Set DayPickerNavigation__horizontal height to 0 #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
approved these changes
Jul 17, 2018
|
@ljharb the variation would be... that there's a global style on all dom elements :/ I'm not super sure that there's a variation that covers this edge case that makes sense to include. |
- For apps with a top-level line-height defined, not having this value set to zero will cause some weird vertical alignment
majapw
force-pushed
the
maja-set-height-on-month-nav
branch
from
d0d2139 to
c3a62fa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a specific edge-case where it turns out that the navigation buttons have an implicit expectation that this value is set to 0. Thus, in an application where there is a top-level line height is set, the navigation and week headers would get shoved down especially when using custom navigation. This change addresses that issue while not affecting existing datepickers.
to: @ljharb