Fix single date picker not responding to input. #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monokrome
commented
Feb 7, 2019
| @@ -253,25 +253,25 @@ class SingleDatePicker extends React.PureComponent { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The changes in this file seem odd, but they are just moving the calls for (add|remove)EventListeners and having them use dayPickerContainer instead.
monokrome
added
the
semver-patch: fixes/refactors/etc
TaeKimJR
approved these changes
Feb 7, 2019
This was referenced Feb 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the 18.4.1 patch, we an issue has occurred where
focusoutalways causes the day picker to close when a click occurs anywhere on the page - even within the day picker itself. This is because the<Portal>is being placed around the day picker instead of it's containers. This PR fixes that issue by placing the handler on a element above the Portal.Thanks to @alvaro-cuesta for discovering this one and letting us know; fixes #1522
/cc @airbnb/ui-frameworks