Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix issue when parent element of component has 'text-align:center',… #258

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Fix issue when parent element of component has 'text-align:center',… #258

merged 1 commit into from
Jan 24, 2017

Conversation

pebf
Copy link
Contributor

@pebf pebf commented Jan 20, 2017

The calendar layout breaks when the DatePicker's parent element is 'text-align:center'. I fixed the problem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.172% when pulling 98b093c on pebf:fix-calendar-align-issue into 0efa253 on airbnb:master.

@ljharb
Copy link
Member

ljharb commented Jan 20, 2017

Duplicate of #257.

@ljharb ljharb closed this Jan 20, 2017
@ljharb
Copy link
Member

ljharb commented Jan 20, 2017

Actually my mistake, this is related but affects a different file.

@ljharb ljharb reopened this Jan 20, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.172% when pulling 98b093c on pebf:fix-calendar-align-issue into 0efa253 on airbnb:master.

majapw
majapw approved these changes Jan 24, 2017
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that #257 might fix this problem separately but probably it is good to have both for increased composeability.

@majapw majapw merged commit dd5def0 into react-dates:master Jan 24, 2017
@majapw majapw mentioned this pull request Jan 25, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pebf @coveralls @ljharb @majapw