Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modify block styling to mean full width on the SingleDatePicker #972

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jan 23, 2018

It is still a bit of an open question for me as to whether or not the DRP inputs should 50% of the block-style question, but it definitely makes sense that the singledatepicker should stretch the full area (and be clickable all the way across). This addresses that concern. :)

to: @ljharb @erin-doyle

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 23, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.667% when pulling 9689f07 on fix-block-styling-on-the-sdp into 1f489e8 on master.

Copy link
Contributor

@noratarano noratarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@ljharb ljharb added semver-minor: new stuff Any feature or API addition. and removed semver-patch: fixes/refactors/etc Anything that's not major or minor. labels Jan 24, 2018
Copy link
Collaborator

@erin-doyle erin-doyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@majapw majapw merged commit 5465237 into master Jan 24, 2018
@majapw majapw deleted the fix-block-styling-on-the-sdp branch January 24, 2018 18:43
@majapw majapw restored the fix-block-styling-on-the-sdp branch February 2, 2018 23:40
@erin-doyle erin-doyle deleted the fix-block-styling-on-the-sdp branch March 26, 2020 17:41
@ljharb ljharb restored the fix-block-styling-on-the-sdp branch March 26, 2020 18:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants