Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/iframe tooltip render #1848

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lapidus
Copy link

@lapidus lapidus commented Jun 3, 2024

🚀 Enhancements

Aims to make XYChart tooltips work in iFrame context.

@williaster
Copy link
Collaborator

williaster commented Jun 6, 2024

Hey @lapidus thanks so much for the PR, could you add a screenshot/video of the fixed trigger and positioning?

@lapidus
Copy link
Author

lapidus commented Jun 6, 2024

Thank you @williaster. The trigger is fixed (the mouseover etc. fires as expected and the tooltips shows up) but I didn't get the positioning 100% right in the PR yet.

I started adding iframe offset logic to this file:
packages/visx-xychart/src/components/Tooltip.tsx

Feel free to add any suggestions to the PR. I'll keep hacking a bit on it and add screenshots 👍

Thanks for the support and a wonderful lib.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XYChart Tooltip not working in Iframe
2 participants