Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inconsistency in required elements and properties in RearrangedSequence and UnrearrangedSequence #789

Open
ustervbo opened this issue May 28, 2024 · 1 comment
Assignees
Labels
GLDB/germlines Germline database WG and Germline schema
Milestone

Comments

@ustervbo
Copy link
Contributor

There appears to be a mismatch in the naming between the required elements and the properties listed in the RearrangedSequence and UnrearrangedSequence objects.

  • In RearrangedSequence, the required list includes repository_id, which does not have a corresponding entry in the properties object. The closest match in properties is repository_ref.
  • Similarly, in UnrearrangedSequence, the required list contains assembly_id, but again, there is no direct match in properties. The nearest property is repository_ref.
@javh javh added this to Germlines Sep 9, 2024
@github-project-automation github-project-automation bot moved this to To do in Germlines Sep 9, 2024
@javh javh added this to the AIRR 2.0 milestone Sep 9, 2024
@javh javh added the GLDB/germlines Germline database WG and Germline schema label Sep 9, 2024
@javh
Copy link
Contributor

javh commented Sep 9, 2024

From the call:

  • required is out of sync with changes to the property names, so we need to fix it.
  • We are missing tests (and test data) for these objects.
  • Put in a PR to resolve.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
GLDB/germlines Germline database WG and Germline schema
Projects
Status: To do
Development

No branches or pull requests

3 participants